@snipe you rightfully mentioned that checking out items from different categories with long EULAs might trigger some truncation or character limit.

Can you look at my overall approach in this PR and let me know if it is worth continuing down this path? If so, I'm tentatively thinking I can account for this by limiting the number of categories being sent per email and potentially including logic around EULA length.

That's an interesting approach. Breaking them out by their EULAs, so each unique EULA gets an email with one or more items in it.... I think I like that.

Moving this to a draft while I hash out the potential truncation or character limit issue.

I deleted the comments from the dev meeting because I think they're ones we can address when they come up. There are for sure some things we'll still need to address, but I think this covers the majority of the use-cases. Nothing is perfect, and as we discussed on the dev meeting, some folks use us in really unusual ways - but I think we can tweak that moving forward as those scenarios arise.

So here's my example, and my proposed solution (which @snipe said she hates, but, well, I should at least write it down).

Let's imagine our categories and EULA's and stuff look like this -

• Default EULA: "You promise not to break this."
• Laptops: "You promise not to break this, and not to pour water on it."
• Mobile Phones: "You promise not to break this, and not to make a bunch of international calls and buy a bunch of PokeCoins with it."
• Printers: "You promise not to break this, and not to pour water on it."
• Scuba gear: - uses default EULA
• Toothbrushes: - uses default EULA
• Mythical creatures from 80's movies: "You promise not to break this, and not to pour water on it."

The thing is, with the current EULA structure, we're going to display and re-display the same EULAs to people a couple of times with our category-centric ways of handling this. So my idea was to normalize the EULAs into their own table. And then you can select which EULA you want for which category (or NULL for 'use default'? Or is that the use-default checkbox?)

With this normalized EULA, we get a few things at the same time - we might be able to store versions of a EULA, to know which one was signed? And we can 'roll up' lists of assets that are checked out to say ORDER BY eula_id and then show the EULA once-and-only-once.

@snipe Yeah, I agree. I think we'll be okay with merging this as is and then figure things out if (as) they bubble up.

Something to consider in the future is moving the logic that groups assets by category from the mailable to the listener so you have a hook to say "is this email too long? let's fire off an email per category instead" or something similar.

I think we'll be okay with merging this as is

I mean "merging as is" after a review of course 😅